Arsnael commented on a change in pull request #803:
URL: https://github.com/apache/james-project/pull/803#discussion_r773026952
##########
File path:
server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPModule.java
##########
@@ -207,7 +207,7 @@ JMAPDraftConfiguration
provideDraftConfiguration(PropertiesProvider propertiesPr
.keystoreType(configuration.getString("tls.keystoreType",
null))
.secret(configuration.getString("tls.secret", null))
.jwtPublicKeyPem(loadPublicKey(fileSystem,
ImmutableList.copyOf(configuration.getStringArray("jwt.publickeypem.url"))))
-
.authenticationStrategies(Optional.ofNullable(configuration.getList(String.class,
"authentication.strategy.draft", null)))
+
.authenticationStrategies(Optional.ofNullable(ImmutableList.copyOf(configuration.getStringArray("authentication.strategy.draft"))))
Review comment:
We always end up with a Some([]) with this... while the initial code
actually is ok on the nullity. I tried as well to add the auth strategies in
jmap.properties in integration tests for jmap rfc8621 and ran
AuthenticationContract and it's green.
Maybe it's what i did with Helm, or I messed up somewhere else... Will test
deeper when I have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
