This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git


The following commit(s) were added to refs/heads/master by this push:
     new a52c724  [boyscout] removes potential flakyness from 
org.apache.james.Pop3ServerContract#deletingAMessageDeletesOnlyOne (#827)
a52c724 is described below

commit a52c7240d65a573ce4de10f8444ea434aa24cc74
Author: Jean Helou <[email protected]>
AuthorDate: Mon Jan 10 02:51:43 2022 +0100

    [boyscout] removes potential flakyness from 
org.apache.james.Pop3ServerContract#deletingAMessageDeletesOnlyOne (#827)
---
 .../src/test/java/org/apache/james/Pop3ServerContract.java         | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/server/apps/distributed-pop3-app/src/test/java/org/apache/james/Pop3ServerContract.java
 
b/server/apps/distributed-pop3-app/src/test/java/org/apache/james/Pop3ServerContract.java
index ae66017..cce2428 100644
--- 
a/server/apps/distributed-pop3-app/src/test/java/org/apache/james/Pop3ServerContract.java
+++ 
b/server/apps/distributed-pop3-app/src/test/java/org/apache/james/Pop3ServerContract.java
@@ -598,19 +598,20 @@ public interface Pop3ServerContract {
         SMTPMessageSender smtpMessageSender = new 
SMTPMessageSender(JMAPTestingConstants.DOMAIN);
         smtpMessageSender.connect("127.0.0.1", 
server.getProbe(SmtpGuiceProbe.class).getSmtpPort());
 
-        IntStream.range(0, 50)
+        var mailCount = 50;
+        IntStream.range(0, mailCount)
             .forEach(Throwing.intConsumer(i -> 
smtpMessageSender.sendMessage("bob@" + JMAPTestingConstants.DOMAIN, USER)));
 
         Awaitility.await().until(() ->
             server.getProbe(MailboxProbeImpl.class)
-                
.searchMessage(MultimailboxesSearchQuery.from(SearchQuery.builder().build()).build(),
 USER, 1).size() == 1);
+                
.searchMessage(MultimailboxesSearchQuery.from(SearchQuery.builder().build()).build(),
 USER, mailCount).size() == mailCount);
 
         // When I delete all of them
         POP3Client pop3Client = new POP3Client();
         pop3Client.connect("127.0.0.1", 
server.getProbe(Pop3GuiceProbe.class).getPop3Port());
         pop3Client.login(USER, PASSWORD);
         List<POP3MessageInfo> pop3MessageInfos = 
ImmutableList.copyOf(pop3Client.listUniqueIdentifiers());
-        assertThat(pop3MessageInfos).hasSize(50);
+        assertThat(pop3MessageInfos).hasSize(mailCount);
         pop3Client.deleteMessage(pop3MessageInfos.get(45).number);
         pop3Client.logout();
 

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to