quantranhong1999 commented on a change in pull request #870:
URL: https://github.com/apache/james-project/pull/870#discussion_r800502575



##########
File path: 
server/mailet/rate-limiter/src/main/scala/org/apache/james/transport/mailets/PerSenderRateLimit.scala
##########
@@ -93,9 +93,9 @@ case class SenderKey(keyPrefix: Option[KeyPrefix], 
entityType: EntityType, mailA
  *  <code>guice.extension.module</code> in <code>extensions.properties</code> 
configuration file. Note that other Rate
  *  limiter implementation might require extra configuration parameters within 
your mailet.</p>
  *
- * @param rateLimiterFactoryProvider Allows instantiations of the underlying 
rate limiters.
+ * @param rateLimiterFactory Allows instantiations of the underlying rate 
limiters.

Review comment:
       Line 91 (it is not changed so I can not comment exactly it): 
   ```
   need to configure a viable option to invoke 
<code>RateLimiterFactoryProvider</code> 
   ```
   => 
   ```
   need to configure a viable option to invoke <code>RateLimiterFactory</code> 
   ```

##########
File path: 
server/mailet/rate-limiter/src/main/scala/org/apache/james/transport/mailets/GlobalRateLimit.scala
##########
@@ -93,9 +93,9 @@ case class GlobalRateLimiter(rateLimiter: 
Option[RateLimiter], keyPrefix: Option
  *  <code>guice.extension.module</code> in <code>extensions.properties</code> 
configuration file. Note that other Rate
  *  limiter implementation might require extra configuration parameters within 
your mailet.</p>
  *
- * @param rateLimiterFactoryProvider Allows instantiations of the underlying 
rate limiters.
+ * @param rateLimiterFactory Allows instantiations of the underlying rate 
limiters.

Review comment:
       Line 91 (it is not changed so I can not comment exactly it):
   ```
   need to configure a viable option to invoke 
<code>RateLimiterFactoryProvider</code> 
   ```
   =>
   ```
   need to configure a viable option to invoke <code>RateLimiterFactory</code> 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to