chibenwa commented on a change in pull request #911:
URL: https://github.com/apache/james-project/pull/911#discussion_r823507119



##########
File path: 
server/container/lifecycle-api/src/main/java/org/apache/james/lifecycle/api/Disposable.java
##########
@@ -29,4 +39,111 @@
      * Dispose the object
      */
     void dispose();
+
+    abstract class LeakAware implements Disposable {

Review comment:
       IMO it make sense from a semantic point of view : as a caller I would 
type `Disposeable.LeakAware` which is very explicit. IMO with separated class 
you loose such a reading.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to