chibenwa commented on a change in pull request #921:
URL: https://github.com/apache/james-project/pull/921#discussion_r829641890
##########
File path: server/apps/cassandra-app/sample-configuration/cassandra.properties
##########
@@ -53,6 +53,7 @@ cassandra.retryConnection.minDelay=5000
# Defaults to false.
# optimistic.consistency.level.enabled=false
-# Optional. Allows to not using lightweight transactions in
CassandraMailRepository.
+# Optional. Allows not to use lightweight transactions in
CassandraMailRepository.
+# Then we implement an idempotent behaviour (duplicates are overridden,
missing entries upon deletes are ignored).
Review comment:
```suggestion
# If disabled we implement an idempotent behaviour (duplicates are
overridden, missing entries upon deletes are ignored).
```
##########
File path:
server/apps/distributed-app/docs/modules/ROOT/pages/configure/cassandra.adoc
##########
@@ -217,5 +217,6 @@ potentially update loss. Better performance are expected
by turning it off. Reads performed as part of write transaction are also
performed with a relaxed consistency.
| mailrepository.strong.consistency
-| Optional. Boolean, defaults to true. Allows to not using lightweight
transactions in CassandraMailRepository.
+| Optional. Boolean, defaults to true. Allows not to use lightweight
transactions in CassandraMailRepository.
+| Then we implement an idempotent behaviour (duplicates are overridden,
missing entries upon deletes are ignored).
Review comment:
```suggestion
| If disabled we implement an idempotent behaviour (duplicates are
overridden, missing entries upon deletes are ignored).
```
##########
File path: server/apps/distributed-app/sample-configuration/cassandra.properties
##########
@@ -53,6 +53,7 @@ cassandra.retryConnection.minDelay=5000
# Defaults to false.
# optimistic.consistency.level.enabled=false
-# Optional. Allows to not using lightweight transactions in
CassandraMailRepository.
+# Optional. Allows not to use lightweight transactions in
CassandraMailRepository.
+# Then we implement an idempotent behaviour (duplicates are overridden,
missing entries upon deletes are ignored).
Review comment:
```suggestion
# If disabled we implement an idempotent behaviour (duplicates are
overridden, missing entries upon deletes are ignored).
```
##########
File path:
server/apps/distributed-pop3-app/sample-configuration/cassandra.properties
##########
@@ -53,6 +53,7 @@ cassandra.retryConnection.minDelay=5000
# Defaults to false.
# optimistic.consistency.level.enabled=false
-# Optional. Allows to not using lightweight transactions in
CassandraMailRepository.
+# Optional. Allows not to use lightweight transactions in
CassandraMailRepository.
+# Then we implement an idempotent behaviour (duplicates are overridden,
missing entries upon deletes are ignored).
Review comment:
```suggestion
# If disabled we implement an idempotent behaviour (duplicates are
overridden, missing entries upon deletes are ignored).
```
##########
File path: src/site/xdoc/server/config-cassandra.xml
##########
@@ -184,7 +184,8 @@
<dd>Optional. Defaults to false. Allows specifying consistency level
ONE for reads in Cassandra BlobStore.
Falls back to default read consistency level if the blob is
missing.</dd>
<dt><strong>mailrepository.strong.consistency</strong></dt>
- <dd>Optional. Defaults to true. Allows to not using lightweight
transactions in CassandraMailRepository.</dd>
+ <dd>Optional. Defaults to true. Allows not to use lightweight
transactions in CassandraMailRepository.
+ Then we implement an idempotent behaviour (duplicates are
overridden, missing entries upon deletes are ignored).</dd>
Review comment:
```suggestion
If disabled we implement an idempotent behaviour (duplicates are
overridden, missing entries upon deletes are ignored).</dd>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
