chibenwa commented on a change in pull request #886:
URL: https://github.com/apache/james-project/pull/886#discussion_r830732513
##########
File path:
protocols/netty/src/main/java/org/apache/james/protocols/netty/AbstractAsyncServer.java
##########
@@ -48,11 +50,12 @@
private volatile int timeout = 120;
- private ServerBootstrap bootstrap;
+ private EventLoopGroup bossGroup;
+ private EventLoopGroup workerGroup;
private volatile boolean started;
- private final ChannelGroup channels = new DefaultChannelGroup();
+ private final ChannelGroup channels = new
DefaultChannelGroup(GlobalEventExecutor.INSTANCE);
Review comment:
Very good suggestion! I'm applying it and will batch it in the next
round of performance tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
