glennosss commented on pull request #924: URL: https://github.com/apache/james-project/pull/924#issuecomment-1074786864
Created pull request as requested! Would you like me to split this commit up a bit, or just leave it for now? My apologies for sending in such a large request - I was trying to clean stuff up to fit into my own project and was finding it near impossible to manage/share EventLoopGroups between different netty servers - so I created https://github.com/glennosss/james-project/blob/netty4-combo/protocols/netty/src/main/java/org/apache/james/protocols/netty/EventLoopGroupManager.java#L34 to solve my and what I believe would be many other peoples biggest problem. Cloud servers these days are often so resource constrained - and splitting this out allows people to easily share thread pools between all their netty servers. I'm also doing a lot of work with Reactor Netty - seems to be the way everyones going these days - and wanted to have good support for async and starting/stopping the server in a very configurable way - so added https://github.com/glennosss/james-project/blob/netty4-combo/protocols/api/src/main/java/org/apache/james/protocols/api/ProtocolServer.java#L88 I fixed the licensing at the top of those files - my bad! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
