This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 181fadb4337496e79b1d230ef302568a6f82955c Author: Benoit Tellier <[email protected]> AuthorDate: Wed May 11 14:13:40 2022 +0700 JAMES-3737 ImapRequestFrameDecoder: remove buggy code Unneeded, the cumulation cary over when disabling framing do not need it. Buggy: next handler do not expect a ByteBuf java.lang.ClassCastException: class io.netty.buffer.PooledDuplicatedByteBuf cannot be cast to class org.apache.james.imap.api.ImapMessage (io.netty.buffer.PooledDuplicatedByteBuf and org.apache.james.imap.api.ImapMessage are in unnamed module of loader 'app') --- .../org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java b/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java index 43ad58a086..88e3b9fb78 100644 --- a/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java +++ b/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoder.java @@ -153,11 +153,6 @@ public class ImapRequestFrameDecoder extends ByteToMessageDecoder implements Net // SwitchableDelimiterBasedFrameDecoder added further to JAMES-1436. disableFraming(ctx); - if (in.readableBytes() > 0) { - ByteBuf spareBytes = in.retainedDuplicate(); - internalBuffer().clear(); - ctx.fireChannelRead(spareBytes); - } in.readerIndex(readerIndex); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
