ottoka commented on code in PR #1274:
URL: https://github.com/apache/james-project/pull/1274#discussion_r1005591468
##########
protocols/api/src/test/java/org/apache/james/protocols/api/AbstractProtocolTransportTest.java:
##########
@@ -81,6 +84,11 @@ public boolean isStartTLSSupported() {
throw new UnsupportedOperationException();
}
+ @Override
+ public Optional<SSLSession> getSSLSession() {
+ throw new UnsupportedOperationException();
Review Comment:
I am following the pattern here, since the method is not used in the tests.
Throwing "unsupported" is different from returning Optional.empty() which would
make it appear as a regular non-SSL transport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
