ottoka commented on PR #1278: URL: https://github.com/apache/james-project/pull/1278#issuecomment-1296871945
The integration tests fail since the FakeSMTP server does not handle an empty sender correctly: `MAIL FROM:<>` `250 2.1.0 Ok` `RCPT TO:<[email protected]>` `503 5.5.1 Error: need MAIL command` Digging further I find https://github.com/andris9/simplesmtp/blob/master/lib/server.js#L403 , which we hit since since Javascript treats undefined/null/empty string all as false. Not sure if this is a feature or a bug in simplesmtp. In either case, I don't have the time to fix a third party project. I could 1. do nothing, drop this PR, close the Jira ticket as won't fix. After all the RFC only has a SHOULD requirement here. - _sad_ 2. disable the vacation integration tests - _bad_ 3. make the sender conditional on a system property or mailet configuration, e.g. "explicitSender=true" would send the address as before, "explicitSender=false" would use the null sender. Default false. - _annoying_ Any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
