Arsnael commented on code in PR #1409:
URL: https://github.com/apache/james-project/pull/1409#discussion_r1088647480
##########
backends-common/pulsar/src/test/java/org/apache/james/backends/pulsar/PulsarConfigurationTest.java:
##########
@@ -155,8 +158,106 @@ void
fromShouldReturnTheConfigurationWhenRequiredParametersAreGiven() {
configuration.addProperty("namespace", namespace);
assertThat(PulsarConfiguration.from(configuration))
- .isEqualTo(new PulsarConfiguration(brokerUri, adminUri, new
Namespace(namespace)));
+ .isEqualTo(new PulsarConfiguration(brokerUri, adminUri, new
Namespace(namespace), Auth.noAuth()));
}
+ @Test
+ void fromShouldThrowWithTokenAuthenticationWhenTokenIsMissing() {
Review Comment:
I don't see then the test that it returns successfully the conf if token
auth params are valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
