This is an automated email from the ASF dual-hosted git repository. matthieu pushed a commit to branch refactorings-2 in repository https://gitbox.apache.org/repos/asf/james-project.git
commit b41f9a97adf152fed33d7729ef5b70ccd9e5bec9 Author: Matthieu Baechler <[email protected]> AuthorDate: Fri Feb 3 08:53:20 2023 +0100 Avoid String comparison when you can match domain types --- .../api/src/main/java/org/apache/james/mailbox/model/ContentType.java | 3 +++ .../org/apache/james/mailbox/store/extractor/DefaultTextExtractor.java | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mailbox/api/src/main/java/org/apache/james/mailbox/model/ContentType.java b/mailbox/api/src/main/java/org/apache/james/mailbox/model/ContentType.java index fa7bf33543..63b25424e9 100644 --- a/mailbox/api/src/main/java/org/apache/james/mailbox/model/ContentType.java +++ b/mailbox/api/src/main/java/org/apache/james/mailbox/model/ContentType.java @@ -99,6 +99,9 @@ public class ContentType { } public static class MediaType { + + public static MediaType TEXT = MediaType.of("text"); + public static MediaType of(String value) { Preconditions.checkState(!Strings.isNullOrEmpty(value), "'media type' is mandatory"); return new MediaType(value); diff --git a/mailbox/store/src/main/java/org/apache/james/mailbox/store/extractor/DefaultTextExtractor.java b/mailbox/store/src/main/java/org/apache/james/mailbox/store/extractor/DefaultTextExtractor.java index 180f263a43..f42ced3a20 100644 --- a/mailbox/store/src/main/java/org/apache/james/mailbox/store/extractor/DefaultTextExtractor.java +++ b/mailbox/store/src/main/java/org/apache/james/mailbox/store/extractor/DefaultTextExtractor.java @@ -43,7 +43,7 @@ import reactor.core.scheduler.Schedulers; public class DefaultTextExtractor implements TextExtractor { @Override public boolean applicable(ContentType contentType) { - return contentType != null && contentType.asString().startsWith("text/"); + return contentType != null && contentType.mediaType().equals(ContentType.MediaType.TEXT); } @Override --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
