chibenwa commented on code in PR #1440:
URL: https://github.com/apache/james-project/pull/1440#discussion_r1104327123
##########
protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java:
##########
@@ -382,7 +382,7 @@ protected Response doAuthTest(SMTPSession session, Username
username, String pas
if (res != null) {
if (SMTPRetCode.AUTH_FAILED.equals(res.getRetCode())) {
- LOGGER.info("AUTH method {} failed", authType);
+ LOGGER.warn("AUTH method {} failed", authType);
} else if (SMTPRetCode.AUTH_OK.equals(res.getRetCode())) {
Review Comment:
I tend to agree with Jean.
Maybe we can discriminate the by having a logger dedicated to failed logging
attemps? EG
`org.apache.james.protocols.smtp.AUTHENTICATION` ?
-> We could put success logs at debug
-> INFO logs for failures
Then this could easily be instrumented if needed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
