Arsnael commented on code in PR #1491:
URL: https://github.com/apache/james-project/pull/1491#discussion_r1141579258


##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxChangesMethodContract.scala:
##########
@@ -1023,6 +1023,70 @@ trait MailboxChangesMethodContract {
       }
     }
 
+    @Test
+    def 
mailboxChangesShouldReturnUpdatedChangesWhenSubscribedOnlyPerUser(server: 
GuiceJamesServer): Unit = {

Review Comment:
   Hmm i get it... My point is if we use the awaitUntil to check tha the 
subscription changes, it's because it's reactive and does not happens right 
away (specially in distributed). So my point is how do we make sure the change 
never happens for the sharee? It could be we check the change happens on Bob... 
but maybe a change happens on Alice later (which we do not want) and we might 
miss it... 
   
   But maybe I'm thinking too much here :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to