This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit a10d2e83001251f3d8cacefde1eac068a8b1fa7b Author: Benoit Tellier <[email protected]> AuthorDate: Wed Apr 12 13:41:56 2023 +0700 [ENHANCEMENT] NettyStreamImapRequestLineReader: Remove no longer relevant TODO --- .../james/imapserver/netty/NettyStreamImapRequestLineReader.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/NettyStreamImapRequestLineReader.java b/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/NettyStreamImapRequestLineReader.java index e0c67c413e..a5b189dab5 100644 --- a/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/NettyStreamImapRequestLineReader.java +++ b/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/NettyStreamImapRequestLineReader.java @@ -106,7 +106,6 @@ public class NettyStreamImapRequestLineReader extends AbstractNettyImapRequestLi */ @Override public char nextChar() throws DecodingException { - if (!nextSeen) { int next; try { @@ -127,8 +126,7 @@ public class NettyStreamImapRequestLineReader extends AbstractNettyImapRequestLi /** * Reads and consumes a number of characters from the underlying reader, - * filling the char array provided. TODO: remove unnecessary copying of - * bits; line reader should maintain an internal ByteBuffer; + * filling the char array provided. * * @param size * number of characters to read and consume @@ -144,7 +142,6 @@ public class NettyStreamImapRequestLineReader extends AbstractNettyImapRequestLi nextSeen = false; nextChar = 0; - //TODO move this copy in netty stack and try to avoid it try { long offset = in.getCount(); in.skip(size); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
