vttranlina commented on code in PR #1510:
URL: https://github.com/apache/james-project/pull/1510#discussion_r1166233397
##########
mailbox/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerAnnotationTest.java:
##########
@@ -105,46 +110,49 @@ void
updateAnnotationsShouldThrowExceptionWhenDoesNotLookupMailbox() {
when(mailboxMapper.findMailboxByPath(eq(mailboxPath))).thenReturn(Mono.error(new
MailboxException()));
assertThatThrownBy(() ->
annotationManager.updateAnnotations(mailboxPath, session,
ImmutableList.of(PRIVATE_ANNOTATION)))
- .hasCauseInstanceOf(MailboxException.class);
+ .isInstanceOf(MailboxException.class);
Review Comment:
Why?
- In `MailboxManagerTest`, we assert by `isInstanceOf` API -> we should keep
similar for both
- The original of this test is `isInstanceOf`, and after commit
5ccf47c38a651653a79283f9f83b491d72b852e9 (JAMES-3167 Reactify MailboxMapper),
we changed it to `hasCauseInstanceOf`, So IMO the revert lit is not a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
