quantranhong1999 commented on code in PR #1501:
URL: https://github.com/apache/james-project/pull/1501#discussion_r1172065387
##########
server/apps/distributed-app/docs/modules/ROOT/pages/configure/smtp-hooks.adoc:
##########
@@ -301,4 +301,21 @@ Example configuration:
<!-- ... -->
<handler
class="org.apache.james.smtpserver.fastfail.ValidSenderDomainHandler"/>
</handlerchain>
+....
+
+== FUTURE-RELEASE hooks
+
+The Distributed server has optional support for DSN
(link:https://www.rfc-editor.org/rfc/rfc4865.html[RFC-4865])
Review Comment:
```suggestion
The Distributed server has optional support for FUTURERELEASE
(link:https://www.rfc-editor.org/rfc/rfc4865.html[RFC-4865])
```
##########
server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/futurerelease/FutureReleaseMailParameterHook.java:
##########
@@ -52,9 +61,9 @@ public HookResult doMailParameter(SMTPSession session, String
paramName, String
if (session.getUsername() == null) {
LOGGER.debug("Needs to be logged in in order to use future release
extension");
return HookResult.builder()
- .hookReturnCode(HookReturnCode.deny())
- .smtpDescription("Needs to be logged in in order to use future
release extension")
- .build();
+ .hookReturnCode(HookReturnCode.deny())
+ .smtpDescription("Needs to be logged in in order to use
future release extension")
+ .build();
Review Comment:
IMO do not change the old indent (check your indent settings).
1 Tab (4 spaces) is good enough, not 2 Tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
