quantranhong1999 commented on code in PR #1561:
URL: https://github.com/apache/james-project/pull/1561#discussion_r1239299354
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/Capability.scala:
##########
@@ -168,6 +168,7 @@ final case class SubmissionCapability(identifier:
CapabilityIdentifier = EMAIL_S
case object SubmissionCapabilityFactory {
val maximumDelays = Duration.ofDays(1)
+ val MAX_FUTURE_RELEASE_INTERVAL = 86400
Review Comment:
```suggestion
```
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/Capability.scala:
##########
@@ -197,7 +198,7 @@ final case class SubmissionCapabilityFactory(clock: Clock,
supportsDelaySends: B
SubmissionCapability(EMAIL_SUBMISSION,
SubmissionProperties(maxDelayedSend, submissionExtensions))
}
-final case class SubmissionProperties(maxDelayedSend: MaxDelayedSend =
MaxDelayedSend(86400),
+final case class SubmissionProperties(maxDelayedSend: MaxDelayedSend =
MaxDelayedSend(MAX_FUTURE_RELEASE_INTERVAL),
Review Comment:
```suggestion
final case class SubmissionProperties(maxDelayedSend: MaxDelayedSend =
MaxDelayedSend(SubmissionCapabilityFactory.maximumDelays.getSeconds.toInt),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]