quantranhong1999 commented on code in PR #1646:
URL: https://github.com/apache/james-project/pull/1646#discussion_r1266105613
##########
third-party/rspamd/src/test/java/org/apache/james/rspamd/DockerClamAV.java:
##########
@@ -41,7 +42,8 @@ public DockerClamAV(Network network) {
.withNetwork(network)
.withCreateContainerCmdModifier(createContainerCmd ->
createContainerCmd.withName("james-clamav-test-" + UUID.randomUUID()))
.withNetworkAliases("clamav")
- .waitingFor(Wait.forHealthcheck());
+ .waitingFor(Wait.forHealthcheck()
+ .withStartupTimeout(Duration.ofMinutes(2)));
Review Comment:
I think a timeout env variable may help for different (slow/fast)
environments.
But as long as we hardcode that timeout high enough, it is still fine for
whatsoever environment. (fast env still finishes starting container regardless
of the timeout)
Let's keep that in mind and let that out of this PR scope IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
