quantranhong1999 commented on code in PR #1652:
URL: https://github.com/apache/james-project/pull/1652#discussion_r1270195348
##########
server/data/data-ldap/src/main/java/org/apache/james/user/ldap/ReadOnlyLDAPUsersDAO.java:
##########
@@ -173,8 +173,8 @@ void dispose() {
ldapConnectionPool.close();
}
- private Filter createFilter(String username) {
- Filter specificUserFilter =
Filter.createEqualityFilter(ldapConfiguration.getUserIdAttribute(), username);
+ private Filter createFilter(String username, String
ldapRetrievalUserAttribute) {
Review Comment:
Yes, otherwise it should fallback to `UserIdAttribute`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
