Arooba-git commented on code in PR #1653: URL: https://github.com/apache/james-project/pull/1653#discussion_r1272406367
########## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageMapper.java: ########## @@ -170,7 +170,16 @@ public Mono<MailboxCounters> getMailboxCountersReactive(Mailbox mailbox) { } return Mono.just(counters); }) - .doOnNext(counters -> readRepair(mailbox, counters)); + .doOnNext(counters -> { + if (this.cassandraConfiguration.getMailboxReadRepair() > 0) { Review Comment: Oh, you mean we should update the name in the original configuration file too? 🤔 <img width="699" alt="Screen Shot 2023-07-25 at 12 13 15 AM" src="https://github.com/apache/james-project/assets/56495631/5861434b-41cb-4aa3-9d18-d1e610045ea9"> ########## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageMapper.java: ########## @@ -170,7 +170,16 @@ public Mono<MailboxCounters> getMailboxCountersReactive(Mailbox mailbox) { } return Mono.just(counters); }) - .doOnNext(counters -> readRepair(mailbox, counters)); + .doOnNext(counters -> { + if (this.cassandraConfiguration.getMailboxReadRepair() > 0) { Review Comment: Oh, you mean we should update the name in the original configuration file too? 🤔 <img width="699" alt="Screen Shot 2023-07-25 at 12 13 15 AM" src="https://github.com/apache/james-project/assets/56495631/5861434b-41cb-4aa3-9d18-d1e610045ea9"> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org