vttranlina commented on code in PR #1671:
URL: https://github.com/apache/james-project/pull/1671#discussion_r1287887236
##########
server/mailet/rate-limiter-redis/src/main/scala/org/apache/james/rate/limiter/redis/RedisHealthCheck.scala:
##########
@@ -0,0 +1,33 @@
+package org.apache.james.rate.limiter.redis
+
+import java.time.Duration
+import java.util.concurrent.TimeUnit
+
+import eu.timepit.refined.auto._
+import javax.inject.Inject
+import org.apache.james.core.healthcheck.{ComponentName, HealthCheck, Result}
+import org.apache.james.rate.limiter.api.{RateLimitingKey, Rule, Rules}
+import org.reactivestreams.Publisher
+import reactor.core.scala.publisher.SMono
+
+import scala.concurrent.duration.FiniteDuration
+
+sealed class RedisHealthCheckKey() extends RateLimitingKey {
+ override def asString(): String = "RedisHealthCheck"
+}
+
+class RedisHealthCheck @Inject()(redisRateLimiterFactory:
RedisRateLimiterFactory) extends HealthCheck {
+ private val COMPONENT_NAME: ComponentName = new ComponentName("Redis")
Review Comment:
it is not a static variable, we should use camelCase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]