quantranhong1999 commented on code in PR #1675:
URL: https://github.com/apache/james-project/pull/1675#discussion_r1293064101
##########
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/S3MinioTest.java:
##########
@@ -120,4 +121,10 @@ void saveShouldWorkForAllPayloadsWithHash() {
.block();
}
+ @Disabled("Minio changed and returns a generic S3Exception instead of a
NoSuchBucketException in its latest release." +
+ "Consequence is trying to delete a blob on a non existing bucket on
MinIO will throw an error, instead of being silenced.")
+ @Override
+ public void deleteShouldNotThrowWhenBucketDoesNotExist() {
+
+ }
Review Comment:
Adapt the test to this would fix the failure for MinIO:
```java
@Test
default void deleteShouldNotThrowWhenBucketDoesNotExist() {
BlobStoreDAO store = testee();
assertThatCode(() ->
Mono.from(store.delete(BucketName.of("not-existing-bucket-name"),
TEST_BLOB_ID)).block())
.doesNotThrowAnyException();
}
```
Rationale: Recently MinIO applies more strictly the rules for bucket names
following AWS S3 standard (no underscore in bucket name)
rf: https://github.com/minio/minio/pull/17742,
https://github.com/conda/conda/pull/12986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
