Arsnael commented on code in PR #1702: URL: https://github.com/apache/james-project/pull/1702#discussion_r1309841561
########## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraCurrentQuotaManagerV2.java: ########## @@ -0,0 +1,129 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.mailbox.cassandra.quota; + +import java.util.List; +import java.util.Optional; +import java.util.function.Predicate; + +import javax.inject.Inject; + +import org.apache.james.backends.cassandra.components.CassandraQuotaCurrentValueDao; +import org.apache.james.backends.cassandra.components.CassandraQuotaCurrentValueDao.QuotaKey; +import org.apache.james.core.quota.QuotaComponent; +import org.apache.james.core.quota.QuotaCountUsage; +import org.apache.james.core.quota.QuotaCurrentValue; +import org.apache.james.core.quota.QuotaSizeUsage; +import org.apache.james.core.quota.QuotaType; +import org.apache.james.mailbox.model.CurrentQuotas; +import org.apache.james.mailbox.model.QuotaOperation; +import org.apache.james.mailbox.model.QuotaRoot; +import org.apache.james.mailbox.quota.CurrentQuotaManager; + +import reactor.core.publisher.Mono; + +public class CassandraCurrentQuotaManagerV2 implements CurrentQuotaManager { + private final CassandraQuotaCurrentValueDao currentValueDao; + + @Inject + public CassandraCurrentQuotaManagerV2(CassandraQuotaCurrentValueDao currentValueDao) { + this.currentValueDao = currentValueDao; + } + + @Override + public Mono<QuotaCountUsage> getCurrentMessageCount(QuotaRoot quotaRoot) { + return currentValueDao.getQuotaCurrentValue(asQuotaKeyCount(quotaRoot)) + .map(QuotaCurrentValue::getCurrentValue) + .map(QuotaCountUsage::count) + .defaultIfEmpty(QuotaCountUsage.count(0L)); + } + + @Override + public Mono<QuotaSizeUsage> getCurrentStorage(QuotaRoot quotaRoot) { + return currentValueDao.getQuotaCurrentValue(asQuotaKeySize(quotaRoot)) + .map(QuotaCurrentValue::getCurrentValue) + .map(QuotaSizeUsage::size) + .defaultIfEmpty(QuotaSizeUsage.size(0L)); + } + + @Override + public Mono<CurrentQuotas> getCurrentQuotas(QuotaRoot quotaRoot) { + return currentValueDao.getQuotasByComponent(QuotaComponent.MAILBOX, quotaRoot.asString()) + .collectList() + .map(this::buildCurrentQuotas); + } + + private CurrentQuotas buildCurrentQuotas(List<QuotaCurrentValue> quotaCurrentValues) { + QuotaCountUsage count = extractQuotaByType(quotaCurrentValues, QuotaType.COUNT) + .map(value -> QuotaCountUsage.count(value.getCurrentValue())) + .orElse(QuotaCountUsage.count(0L)); + + QuotaSizeUsage size = extractQuotaByType(quotaCurrentValues, QuotaType.SIZE) + .map(value -> QuotaSizeUsage.size(value.getCurrentValue())) + .orElse(QuotaSizeUsage.size(0L)); + + return new CurrentQuotas(count, size); + } + + private Optional<QuotaCurrentValue> extractQuotaByType(List<QuotaCurrentValue> quotaCurrentValues, QuotaType quotaType) { + return quotaCurrentValues.stream() + .filter(quotaValue -> quotaValue.getQuotaType().equals(quotaType)) + .findAny(); + } + + @Override + public Mono<Void> increase(QuotaOperation quotaOperation) { + return currentValueDao.increase(asQuotaKeyCount(quotaOperation.quotaRoot()), quotaOperation.count().asLong()) + .then(currentValueDao.increase(asQuotaKeySize(quotaOperation.quotaRoot()), quotaOperation.size().asLong())); + } + + @Override + public Mono<Void> decrease(QuotaOperation quotaOperation) { + return decrease(quotaOperation.quotaRoot(), quotaOperation.count(), quotaOperation.size()); + } + + private Mono<Void> decrease(QuotaRoot quotaRoot, QuotaCountUsage count, QuotaSizeUsage size) { + return currentValueDao.decrease(asQuotaKeyCount(quotaRoot), count.asLong()) + .then(currentValueDao.decrease(asQuotaKeySize(quotaRoot), size.asLong())); + } + + @Override + public Mono<Void> setCurrentQuotas(QuotaOperation quotaOperation) { + return getCurrentQuotas(quotaOperation.quotaRoot()) + .filter(Predicate.not(Predicate.isEqual(CurrentQuotas.from(quotaOperation)))) + .flatMap(storedQuotas -> decrease(quotaOperation.quotaRoot(), storedQuotas.count(), storedQuotas.size()) Review Comment: cf fixed in https://github.com/apache/james-project/pull/1702/commits/85bef866fb552c5935b0273782f232dae61e2806 Didnt want to make a fixup, the CI seems too capricious lately, would be happy to not have to squash and wait again after a green build :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
