quantranhong1999 commented on code in PR #1707:
URL: https://github.com/apache/james-project/pull/1707#discussion_r1316805533
##########
server/protocols/webadmin/webadmin-mailbox/src/main/java/org/apache/james/webadmin/routes/UserQuotaRoutes.java:
##########
@@ -99,17 +101,22 @@ private static Optional<Integer> intQueryParameter(Request
request) {
}
}
- private static Optional<QuotaComponent> getQuotaComponent(Request
request) {
- String quotaComponentString =
request.queryParams(USERS_PER_SECOND);
- if (Objects.isNull(quotaComponentString)) {
- return Optional.empty();
+ private static List<QuotaComponent> getQuotaComponent(Request request)
{
+ List<QuotaComponent> quotaComponents = new ArrayList<>();
+ String[] quotaComponentStrings =
request.queryParamsValues(QUOTA_COMPONENT);
Review Comment:
How about something like this:
```java
return Arrays.stream(quotaComponentStrings)
.map(quotaComponentString -> {
QuotaComponent quotaComponent =
QUOTA_COMPONENT_MAP.get(quotaComponentString);
if (Objects.isNull(quotaComponent)) {
throw new
IllegalArgumentException(String.format("Illegal value supplied for query
parameter '%s' with value '%s', expecting existing " +
"quota components", QUOTA_COMPONENT,
quotaComponentString));
}
return quotaComponent;
})
.collect(Collectors.toUnmodifiableList());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
