chibenwa commented on code in PR #1707:
URL: https://github.com/apache/james-project/pull/1707#discussion_r1320025805
##########
server/mailet/integration-testing/src/main/java/org/apache/james/mailets/TemporaryJamesServer.java:
##########
@@ -155,7 +157,10 @@ private TemporaryJamesServer(File workingDir,
MailetContainer mailetContainer, S
.overrideWith((binder) ->
binder.bind(PersistenceAdapter.class).to(MemoryPersistenceAdapter.class))
.overrideWith(additionalModules)
.overrideWith(new TestJMAPServerModule())
- .overrideWith((binder) ->
binder.bind(WebAdminConfiguration.class).toInstance(WebAdminConfiguration.TEST_CONFIGURATION));
+ .overrideWith((binder) -> {
+
binder.bind(WebAdminConfiguration.class).toInstance(WebAdminConfiguration.TEST_CONFIGURATION);
+
binder.bind(UploadRepository.class).to(UnsupportedUploadRepository.class);
+ });
Review Comment:
There is something wrong here.
`UnsupportedUploadRepository` is an heresie.
Please instead provide a modular enough design to only expose operation
supported by the james server that is running.
Likely some dark magic with a multibinder should do the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
