chibenwa commented on code in PR #1707:
URL: https://github.com/apache/james-project/pull/1707#discussion_r1325748171
##########
mailbox/tools/quota-recompute/pom.xml:
##########
@@ -46,6 +46,10 @@
<groupId>${james.groupId}</groupId>
<artifactId>james-server-data-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-data-jmap</artifactId>
+ </dependency>
Review Comment:
No we MUST not add this dependency here.
We MUST provide a way to inject our components without requiring a hard
dependency.
We still do not obey to the word to the othogonal architeture and still need
to further polish the implementation here to avoid uneeded dependencies before
I can approuve this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
