thanhbv200585 commented on code in PR #1743:
URL: https://github.com/apache/james-project/pull/1743#discussion_r1361046462
##########
protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java:
##########
@@ -100,6 +100,7 @@ protected void doAuth(AuthenticationAttempt
authenticationAttempt, ImapSession s
session.stopDetectingCommandInjection();
} catch (BadCredentialsException e) {
authFailure = true;
+ LOGGER.info("User {} failed authentication",
authenticationAttempt.getAuthenticationId().asString());
Review Comment:
Yep, for sure. But it take a little time to add some info. So far, there is
no information about IP in log from AuditTrail when login failed
`{"timestamp":"2023-10-16T17:48:05.839Z","level":"INFO","thread":"imapserver-io-8","mdc":{"protocol":"IMAP","remoteIP":"","action":"AUTH","userAgent":"","sessionId":"","parameters":"{}","username":"user1@localhost"},"logger":"org.apache.james.util.AuditTrail","message":"IMAP
Authentication failed because of bad credentials.","context":"default"}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
