quantranhong1999 commented on PR #1824: URL: https://github.com/apache/james-project/pull/1824#issuecomment-1831317998
> I have problem in duplicated binding. Hope team to find out and catch this bug :))) Reason: Guice does not accept 2 beans for the same default `Set<ConnectionCheck>`, we need to aggregate James provided connection checks with additional connection checks (e.g. `CrowdSecConnectionCheck`). Likely you would need to do something similar with `additional.healthchecks`: https://github.com/apache/james-project/blob/master/examples/custom-healthcheck/README.md#L34. e.g. `additional.connectionchecks=org.apache.james.CustomConnectionCheck`. And aggregate the extension connection checks to the `Set<ConnectionCheck>` bean like what we did with additional healthcheck: https://github.com/apache/james-project/blob/master/server/container/guice/common/src/main/java/org/apache/james/modules/PeriodicalHealthChecksModule.java#L64 Maybe other people can have a better idea as well... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
