quantranhong1999 commented on code in PR #1824:
URL: https://github.com/apache/james-project/pull/1824#discussion_r1432353981
##########
protocols/imap/pom.xml:
##########
@@ -60,6 +60,11 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-guice-utils</artifactId>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
not resolved yet.
##########
protocols/imap/src/main/java/org/apache/james/imap/api/ImapConfiguration.java:
##########
@@ -173,8 +181,9 @@ public ImapConfiguration build() {
private final boolean isCondstoreEnable;
private final boolean provisionDefaultMailboxes;
private final Properties customProperties;
+ private final ImmutableSet<String> connectionChecks;
Review Comment:
```suggestion
private final ImmutableSet<String> additionalConnectionChecks;
```
to distinguish with built-in connection check.
Shift+F6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
