vttranlina commented on code in PR #1925:
URL: https://github.com/apache/james-project/pull/1925#discussion_r1456860235


##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/PostgresMailboxSessionMapperFactory.java:
##########
@@ -115,11 +116,12 @@ public PostgresModSeqProvider 
getModSeqProvider(MailboxSession session) {
 
     @Override
     public AttachmentMapper createAttachmentMapper(MailboxSession session) {
-        throw new NotImplementedException("not implemented");
+        PostgresAttachmentDAO postgresAttachmentDAO = new 
PostgresAttachmentDAO(executorFactory.create(session.getUser().getDomainPart()),
 blobIdFactory);
+        return new PostgresAttachmentMapper(postgresAttachmentDAO, blobStore);
     }
 
     @Override
     public AttachmentMapper getAttachmentMapper(MailboxSession session) {
-        throw new NotImplementedException("not implemented");
+        return createAttachmentMapper(session);

Review Comment:
   A bit unsure here, 
   both create and get methods will create new attachmentMapper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to