vttranlina commented on code in PR #1925:
URL: https://github.com/apache/james-project/pull/1925#discussion_r1458255609
##########
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/DeleteMessageListener.java:
##########
@@ -146,4 +153,8 @@ private Mono<Boolean> isUnreferenced(PostgresMessageId id,
PostgresMailboxMessag
.map(count -> true)
.defaultIfEmpty(false);
}
+
+ private Mono<Void> deleteAttachment(PostgresMessageId messageId,
PostgresAttachmentDAO attachmentDAO) {
+ return attachmentDAO.deleteByMessageId(messageId);
Review Comment:
> e.g. DeduplicationBlobStore, where the same attachments would share the
same object in the blob store.
DeduplicationBlobStore.deleteBlob always return false, and it do nothing.
```scala
override def delete(bucketName: BucketName, blobId: BlobId):
Publisher[java.lang.Boolean] = {
Preconditions.checkNotNull(bucketName)
Preconditions.checkNotNull(blobId)
SMono.just(Boolean.box(false))
}
```
The trying to delete blob when using DeduplicationBlobStore doesn't make
sense. But yes if PassThroughBlobStore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
