Arsnael commented on code in PR #1981:
URL: https://github.com/apache/james-project/pull/1981#discussion_r1479395680
##########
server/blob/blob-api/src/test/java/org/apache/james/blob/api/ReadSaveBlobStoreDAOContract.java:
##########
@@ -236,7 +236,7 @@ default void saveBytesShouldBeIdempotent(String
description, byte[] bytes) {
@MethodSource("blobs")
default void saveByteSourceShouldBeIdempotent(String description, byte[]
bytes) {
BlobStoreDAO store = testee();
- Mono.from(store.save(TEST_BUCKET_NAME, TEST_BLOB_ID,
ByteSource.wrap(bytes))).block();
+ Mono.from(store.save(TEST_BUCKET_NAME, TEST_BLOB_ID,
TWELVE_MEGABYTES)).block();
Review Comment:
Not sure if it's acceptable or not....
It seems for some reason first save fails if it's with the ByteSource or
InputStream with a big blob, but not with the direct bytes. Also if before the
two ByteSource big blob saves you do a save on a smaller blob, then it's green.
It's rather odd and I don't really understand what's going on there, if it's
related to MinIO warming up or bucket data init... Will try to dig more but...
looks rather weird to me.
If someone else with more object storage or MinIO knowledge wants to have a
look as well, feel free :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
