Arsnael commented on code in PR #2005:
URL: https://github.com/apache/james-project/pull/2005#discussion_r1491959555
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/Email.scala:
##########
@@ -610,7 +610,7 @@ private class EmailFullViewFactory
@Inject()(zoneIdProvider: ZoneIdProvider, pre
.getOrElse(Failure(new IllegalArgumentException("No message
supplied")))
mime4JMessage <- Email.parseAsMime4JMessage(firstMessage)
blobId <- BlobId.of(messageId)
- bodyStructure <- EmailBodyPart.ofMessage(request.bodyProperties,
zoneIdProvider.get(), blobId, mime4JMessage, firstMessage.getSize)
+ bodyStructure <- EmailBodyPart.ofMessage(request.bodyProperties,
zoneIdProvider.get(), blobId, mime4JMessage, firstMessage.getBody.size)
Review Comment:
Was putting the full message size for the body one
Reduced failing tests from 5 to 1 on EmailGetMethodContract
There is still a problem with `bodyStructureForSimpleMultipart` test, size
difference of 2 (actual 2285, expected 2287). Dont know if it's right and
previous code wrong or if there is a little trick here.
Will check back after lunch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
