chibenwa commented on code in PR #2026:
URL: https://github.com/apache/james-project/pull/2026#discussion_r1494227774
##########
server/data/data-ldap/src/main/java/org/apache/james/user/ldap/ReadOnlyLDAPUser.java:
##########
@@ -129,7 +129,7 @@ public boolean verifyPassword(String password) {
try {
BindResult bindResult =
connectionPool.bindAndRevertAuthentication(userDN.toString(), password);
return bindResult.getResultCode() == ResultCode.SUCCESS;
- } catch (LDAPBindException e) {
+ } catch (LDAPException e) {
Review Comment:
:-1: I fear we reject overwise valuable information.
How about instead interception the empty password before calling the LDAP,
logging the info, and then return straight away a failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
