quantranhong1999 commented on code in PR #2029:
URL: https://github.com/apache/james-project/pull/2029#discussion_r1507052801
##########
server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/distributed/DistributedAuthenticationTest.java:
##########
@@ -52,6 +52,5 @@ class DistributedAuthenticationTest implements
AuthenticationContract {
.extension(new AwsS3BlobStoreExtension())
.server(configuration ->
CassandraRabbitMQJamesServerMain.createServer(configuration)
.overrideWith(new TestJMAPServerModule()))
- .lifeCycle(JamesServerExtension.Lifecycle.PER_ENCLOSING_CLASS)
Review Comment:
I tend to agree with @Arsnael. We should not modify the contract test unless
something is actually wrong with the contract test itself.
@hungphan227 maybe try more on releasing the connection upon James shutdown?
As I think the production code deserves the connection release as well.
e.g. add this to the `SinglePostgresConnectionFactory`
```
@PreDestroy
public void dispose() {
Mono.from(connection.close()).block();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
