Maxxx873 commented on PR #2197: URL: https://github.com/apache/james-project/pull/2197#issuecomment-2052139758
> Hello, > > Thanks to put this together! > > While the datastructure for the memory structure is not optimal (`O(N)` scans) And while we could easily do better (one multimap for global scope, one table for domain scope, one table for user scope) this does not matter much performance wise in a testing environment. > > Other remarks however likely deserve attention. Thanks for the excellent code review! I will try to correct everything that was pointed out to me in the remarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
