chibenwa commented on code in PR #2263:
URL: https://github.com/apache/james-project/pull/2263#discussion_r1616657169


##########
server/apps/distributed-app/docs/modules/ROOT/pages/configure/index.adoc:
##########
@@ -52,6 +52,7 @@ By omitting these files, sane default values are used.
 ** xref:configure/recipientrewritetable.adoc[*recipientrewritetable.xml*] 
enables advanced configuration for the Recipient Rewrite Table component 
link:https://github.com/apache/james-project/blob/master/server/apps/distributed-app/sample-configuration/recipientrewritetable.xml[example]
 *** xref:configure/matchers.adoc[This page] allows choosing the indexing 
technology.
 ** xref:configure/usersrepository.adoc[*usersrepository.xml*] allows 
configuration of user storage 
link:https://github.com/apache/james-project/blob/master/server/apps/distributed-app/sample-configuration/usersrepository.xml[example]
+** xref:configure/droplists.adoc[This page] allows configuring drop lists.

Review Comment:
   I would move this down into "extensions" as this is not enabled by default 
this likely isn't "core"



##########
server/apps/distributed-app/docs/modules/ROOT/pages/configure/droplists.adoc:
##########
@@ -0,0 +1,26 @@
+= Distributed James Server — DropLists
+:navtitle: DropLists
+
+The DropList, also known as the mail blacklist, is a collection of
+domains and email addresses that are denied from sending emails within the 
system.
+It is disabled by default.
+To enable it, modify the `droplists.properties` file and include the 
`IsInDropList` matcher in the `mailetcontainer.xml`.
+To disable it, adjust the `droplists.properties` file and remove the 
`IsInDropList` matcher from the `mailetcontainer.xml`.
+
+.droplists.properties content
+|===
+| Property name | explanation
+
+| enabled
+| true/false. Governs whether DropLists should be enabled

Review Comment:
   Please indicate the default value. And the fact that we expect a `Boolean`.



##########
server/apps/distributed-app/docs/modules/ROOT/pages/configure/droplists.adoc:
##########
@@ -0,0 +1,26 @@
+= Distributed James Server — DropLists
+:navtitle: DropLists
+
+The DropList, also known as the mail blacklist, is a collection of
+domains and email addresses that are denied from sending emails within the 
system.
+It is disabled by default.
+To enable it, modify the `droplists.properties` file and include the 
`IsInDropList` matcher in the `mailetcontainer.xml`.
+To disable it, adjust the `droplists.properties` file and remove the 
`IsInDropList` matcher from the `mailetcontainer.xml`.

Review Comment:
   Please indicate me how I can add entries onto my bloclist!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to