vttranlina commented on code in PR #2267:
URL: https://github.com/apache/james-project/pull/2267#discussion_r1625213513
##########
server/data/data-jmap-postgres/src/main/java/org/apache/james/jmap/postgres/change/PostgresMailboxChangeDAO.java:
##########
@@ -62,6 +63,14 @@ public Mono<Void> insert(MailboxChange change) {
.set(CREATED, toUUIDArray(change.getCreated()))
.set(UPDATED, toUUIDArray(change.getUpdated()))
.set(DESTROYED, toUUIDArray(change.getDestroyed()))
+ .set(DATE, change.getDate().toOffsetDateTime())
+ .onConflictOnConstraint(PRIMARY_KEY_CONSTRAINT_NAME)
Review Comment:
The state value is
`UuidCreator.getTimeOrderedEpoch()`
I don't think it needs to "do Update on Conflict...", It looks like pr tried
to fix it for stable testing, not for real-world
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
