Arsnael commented on PR #2342:
URL: https://github.com/apache/james-project/pull/2342#issuecomment-2224253095

   I think something is wrong with flags update in general, and maybe the 
search query on flags too.
   
   On testSearch tests, I tried to modify a bit the script. I tried to add the 
flag flagged to just messages 3 and 4 and do a search on it, it returns 3 and 4.
   
   But then search unflagged => returns all messages.
   
   I tried to debug yesterday as well, I felt like maybe (aint completely sure) 
we were creating more documents each time with updates...
   
   I think we might need to review the flags part of the code. In the 
createFlagQuery for example you can see some comments like `// lucene does not 
support simple NOT queries so we do some nasty hack here` . Maybe 
lucenesupports it now for example and the hack is creating issues now? Things 
like that...
   
    Or also I wondered why flags and messages are being in separated documents 
with lucene? Was it because of some limitations of the version 2? Maybe would 
make sense in latest version to have it all organized in just one document? It 
looks like to me we have it all in one doc in opensearch for example if I'm not 
wrong


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to