woj-tek commented on PR #2342: URL: https://github.com/apache/james-project/pull/2342#issuecomment-2282707335
Changes in https://github.com/tigase/james-project/commit/e5fe4010131f085754cfadcffdb14224612bb848 Not sure how to submit those to James repo/this PR (I used `gh` to checkout this PR, should I create yet another PR? It seems like the only option). The branch itself: https://github.com/tigase/james-project/tree/lucene-flags-test. Both `james-project/mailbox/lucene` and `james-project/mpt/impl/imap-mailbox/lucenesearch` builds correctly while running `mvn clean install -Dcheckstyle.skip=true` The only thing that "doesn't work" is checking state of the Lucene repository after running the test - it should has only 8 documents but reports 10... (line 358 in [LuceneMailboxMessageFlagSearchTest.java](https://github.com/tigase/james-project/commit/e5fe4010131f085754cfadcffdb14224612bb848#diff-78136c4e5a4cffcb5833742990d67ff2f6400c7acb6e370c761ae4c56623535aR358)) It doesn't impact queries for particular message flag documents but still it is a discrepancy. I read that one should check if document is marked as deleted but I think it applies to older Lucene version and I havent't seen similar API in current/updated version. As I said - it's checking Lucene internals so I commented out -- I think it's not relevant here but left it so it could be checked. PS. If someone has a formatter for IDEA that would produce sources formatted to checkstyle liking I'd be very thankfull if shared :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
