jeantil commented on code in PR #2417:
URL: https://github.com/apache/james-project/pull/2417#discussion_r1768447247
##########
pom.xml:
##########
@@ -3326,7 +3326,7 @@
<reuseForks>true</reuseForks>
<!-- Fail tests longer than 30 minutes, prevent form
random locking tests -->
<forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
- <excludedGroups>unstable</excludedGroups>
Review Comment:
well I'm not entirely sure.
without this change the command
```
mvn clean test
-Dtest=org.apache.james.linshare.LinshareBlobExportMechanismTest
-Dsurefire.failIfNoSpecifiedTests=false -am -pl :apache-james-linshare
-Dcheckstyle.skip -Punstable-tests
```
doesn´t execute anything, with the change it does run the corresponding
tests.
but there are tests that are tagged `BasicFeature`, unless their module has
a custom surefire config to include these tests, they would be excluded by the
change i applied
so we probably need something more involved such as `none() | BasicFeature`
group settings for junit5 are documented at
https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#filtering-by-tags
and if I understand correctly it is to be combined with
https://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions
to produce the proper selection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
