chibenwa commented on code in PR #2419:
URL: https://github.com/apache/james-project/pull/2419#discussion_r1771146885
##########
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/SubAddressingTest.java:
##########
@@ -97,43 +97,106 @@ void tearDown() throws IOException {
void
subAddressedEmailShouldBeDeliveredInINBOXWhenSpecifiedFolderDoesNotExist(@TempDir
File temporaryFolder) throws Exception {
setup(temporaryFolder);
- //do not create mailbox
+ // do not create mailbox
+ assertThat(testIMAPClient.sendCommand("GETACL " +
TARGETED_MAILBOX)).contains("Mailbox not found");
sendSubAddressedMail();
awaitSubAddressedMail(MailboxConstants.INBOX);
}
@Test
- void subAddressedEmailShouldBeDeliveredInINBOXWhenNoRights(@TempDir File
temporaryFolder) throws Exception {
+ void subAddressedEmailShouldBeDeliveredInINBOXWhenNobodyHasRight(@TempDir
File temporaryFolder) throws Exception {
setup(temporaryFolder);
// create mailbox
- testIMAPClient.connect(LOCALHOST_IP,
jamesServer.getProbe(ImapGuiceProbe.class).getImapPort())
- .login(RECIPIENT, PASSWORD)
- .create(TARGETED_MAILBOX);
+ testIMAPClient.sendCommand("CREATE " + TARGETED_MAILBOX);
+ assertThat(testIMAPClient.sendCommand("GETACL " +
TARGETED_MAILBOX)).contains("OK GETACL");
Review Comment:
Tests are supposed to get only a single assertion. THis allow making clear
what is tested.
If intermediate states are unsure, this likely means a distinct test shall
be added, covering explicitly the effects of SETACL. Also those very valuable
tests have not much to do with subadressing and shall be done in dedicated
location (RIghts.script in mpt-core ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
