Arsnael commented on PR #2410: URL: https://github.com/apache/james-project/pull/2410#issuecomment-2378282341
Alright the code seems ok now, I will merge and squash all of this on github's end. Just maybe for next time, on your PR instead of doing numerous git merge with master that lead to absolute commit mess (40+ commits... it makes it hard to review), prefer maybe the git rebase instead? Like on your local branch : ``` git fetch apache master git rebase apache/master [fix conflicts if necessary] git push origin HEAD -f ``` Would help keep a clean commit history, in sync with master branch, with making life of people reviewing your PR easier. Thank you for the contribution though, kindly appreciated :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
