florentos17 commented on PR #2419: URL: https://github.com/apache/james-project/pull/2419#issuecomment-2378620990
> Common practice on the project and with git: > > Fixups should start with `fixup! [COMMIT]`. > > Like if you have a commit `JAMES-3945 rights positioning with IMAP in integration tests` a fixup for this commit would be: `fixup! JAMES-3945 rights positioning with IMAP in integration tests` > > Makes it easier for reviewers to know what is being fixed and also easier to squash up and have have a clean git history merged. > > It's ok I think to squash all those commits into one here so I will merge, just think about it for the next time :) Yes, I intended to squash the fixups once the tests would pass and before merging, but you're right anyway, thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
