vttranlina commented on code in PR #2447: URL: https://github.com/apache/james-project/pull/2447#discussion_r1795059511
########## mailbox/api/src/test/java/org/apache/james/mailbox/searchhighligt/SearchHighLighterContract.java: ########## @@ -64,14 +65,14 @@ default void highlightSearchShouldReturnHighLightedSubjectWhenMatched() throws E ComposedMessageId m1 = appendMessage(MessageManager.AppendCommand.from( Message.Builder.of() .setTo("to@james.local") - .setSubject("Hallo! Thx Matthieu for your help") + .setSubject("Hallo, Thx Matthieu for your help") Review Comment: I don't understand why the character "!" causes the highlight results to exclude `Hallo!`. I attempted various highlight configurations while querying, but none worked as expected. When indexing `subject`, I replaced the tokenizer `uax_url_email` with `standard`, but that didn't work either. To simplify the test case for Lucene and OpenSearch, I changed `!` to `,`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org