Arsnael commented on code in PR #2446:
URL: https://github.com/apache/james-project/pull/2446#discussion_r1796323473
##########
server/protocols/protocols-smtp-dkim/src/main/java/org/apache/james/smtpserver/DKIMHook.java:
##########
@@ -165,7 +205,9 @@ public Config(boolean forceCRLF, boolean signatureRequired,
Optional<Domain> onl
DKIMCheckNeeded dkimCheckNeeded() {
return onlyForSenderDomain
- .map(DKIMCheckNeeded::onlyForSenderDomain)
+ .map(domain -> DKIMCheckNeeded.or(
+ DKIMCheckNeeded.onlyForSenderDomain(domain),
+ DKIMCheckNeeded.onlyForHeaderFromDomain(domain)))
Review Comment:
Doable yes, more flexibility is good. Will give it a shot, thanks for the
suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
