chibenwa commented on code in PR #2448: URL: https://github.com/apache/james-project/pull/2448#discussion_r1798894280
########## server/mailet/integration-testing/src/main/resources/smtpserver.xml: ########## @@ -87,7 +87,11 @@ <handler class="org.apache.james.smtpserver.fastfail.ValidRcptHandler"/> <handler class="org.apache.james.smtpserver.CoreCmdHandlerLoader"/> {{#hooks}} - <handler class="{{hookFqcn}}"/> + <handler class="{{hookFqcn}}"> + {{#hookConfigAsXML}} + <MaxRcptCount>{{value}}</MaxRcptCount> Review Comment: The key is not necessarily maxRcptCount but needs to be taken from the key of the map. Please write unit tests for this class using an entry the is not MaxRcptCount... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org