vttranlina commented on code in PR #2450:
URL: https://github.com/apache/james-project/pull/2450#discussion_r1799117617


##########
examples/oidc/apisix/conf/apisix.yaml:
##########
@@ -11,6 +11,9 @@ routes:
     plugins:
       proxy-rewrite:
         uri: /jmap
+        headers:
+          set:
+            X-User-Secret: ${{X_USER_SECRET}}

Review Comment:
   > Please also make sure the clients have no way to pass X-USER headers
   
   for basic auth, it was done by `jmap_service_basic_auth` 
   for oidc auth, it was done by `RewriteXUserFilter` plugin 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to