Arsnael commented on code in PR #2454:
URL: https://github.com/apache/james-project/pull/2454#discussion_r1802290192
##########
docs/modules/servers/partials/operate/webadmin.adoc:
##########
@@ -2567,6 +2567,67 @@ Response codes:
* 204: The quota has been updated to unlimited value.
+===== Domain DropList
Review Comment:
Missing the upper section declaration `Add entry to the DropList`?
Also missing global adding?
##########
docs/modules/servers/partials/operate/cli.adoc:
##########
@@ -272,6 +288,49 @@ level. Note: syntax is similar to what was exposed
previously.
{cli} GetGlobalMaxStorageQuota
....
+=== Manage DropList
+
+The DropList, also known as the mail blacklist, is a collection of
+domains and email addresses that are denied from sending emails within
+the system.
+
+Owner scopes:
+
+* `global`: contains entries that are blocked across all domains and
+addresses within the system. Entries in the global owner scope apply
+universally and affect all users and domains.
+* `domain`: each domain can have its own droplist, which contains
+entries specific to that domain.
+* `user`: allow to customize personalized droplist of blocked domains
+and email addresses.
+
+See example commands for `domain` owner scope, `ow...@owner.com`
+owner, `e...@devil.com` denied entity.
+
+Add Entry to the DropList
+
+....
+{cli} AddDropListEntry domain ow...@owner.com e...@devil.com
Review Comment:
If the example is about the domain, shouldn't the command be then:
```
{cli} AddDropListEntry domain owner.com e...@devil.com
```
Idem for below examples?
##########
src/site/markdown/server/manage-cli.md:
##########
@@ -290,6 +291,45 @@ Moreover, James allows to specify global maximum values,
at the server level. No
{cli} GetGlobalMaxStorageQuota
```
+## Manage DropList
+
+The DropList, also known as the mail blacklist, is a collection of
+domains and email addresses that are denied from sending emails within the
system.
+
+Owner scopes:
+
+- `global`: contains entries that are blocked across all domains and addresses
within the system.
+ Entries in the global owner scope apply universally and affect all users and
domains.
+- `domain`: each domain can have its own droplist, which contains entries
specific to that domain.
+- `user`: allow to customize personalized droplist of blocked domains and
email addresses.
+
+See example commands for `domain` owner scope, `ow...@owner.com` owner,
`e...@devil.com` denied entity.
+
+Add Entry to the DropList
+
+```
+{cli} AddDropListEntry domain ow...@owner.com e...@devil.com
Review Comment:
Same remark as above
##########
docs/modules/servers/partials/operate/webadmin.adoc:
##########
@@ -2567,6 +2567,67 @@ Response codes:
* 204: The quota has been updated to unlimited value.
+===== Domain DropList
Review Comment:
Having a pass again for some reason it seems the droplist section aint
present in the antora doc at all! I don't know if we missed that when
introducing the droplist or if it got lost when we were refactoring the antora
doc (if it's the case, sorry)
Then we probably need to add more globally the droplist section as well, as
`Getting the DropList` and `Testing a denied entity existence` subsections, to
have something similar to
https://james.apache.org/server/manage-webadmin.html#administrating-droplists
You think you can help with that @Maxxx873 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
